feat: add enrollment details to public hidden key#2020
feat: add enrollment details to public hidden key#2020murali-shris wants to merge 2 commits intotrunkfrom
Conversation
|
Have added @cconstab and @xavierchanth as reviewers as I'd like this change to have more eyes on it before we merge it |
| String newEnrollmentId, | ||
| EnrollDataStoreValue enrollmentDataStoreValue, | ||
| String currentAtSign) async { | ||
| var key = 'public:$enrollmentPublicHiddenKey'; |
There was a problem hiding this comment.
Wait does this actually work as intended? A public key with _ is also hidden? I was under the impression that this was only for self-keys, but it makes sense that it works for all key types.
If so, the changes I proposed in atsign-foundation/at_protocol#166 are not quite right.
No action items for this PR intended out of this comment, but rather clarification for the changes I am making to the protocol spec.
gkc
left a comment
gkc
left a comment
There was a problem hiding this comment.
As discussed let's park this while we revisit the problem we're trying to solve and come up with the desired user experience first. As it stands, this would leak information which a user might not at all want
| response, approveEnrollVerbParams, inboundConnection); | ||
| expect(jsonDecode(response.data!)['enrollmentId'], enrollmentId); | ||
| expect(jsonDecode(response.data!)['status'], 'approved'); | ||
| // verify enrollmentId is present in hidden public key before enroll:revoke |
There was a problem hiding this comment.
This should be made into its own unit test rather than added to an existing one
| expect(jsonDecode(response.data!)['enrollmentId'], enrollmentId); | ||
| expect(jsonDecode(response.data!)['status'], 'revoked'); | ||
| // verify enrollmentId is removed from hidden public key after enroll:revoke | ||
| enrollmentAtData = await secondaryKeyStore |
There was a problem hiding this comment.
This should be made into its own unit test rather than added to an existing one
| expect(enrollmentData!.metaData!.expiresAt, null); | ||
| expect(enrollmentData.metaData!.ttl, 0); | ||
| var enrollmentAtData = await secondaryKeyStore | ||
| .get('public:$enrollmentPublicHiddenKey$alice'); |
There was a problem hiding this comment.
This should be made into its own unit test rather than added to an existing one
3 participants
- What I did
- How I did it
- How to verify it