Skip to content

Fix prebuilt deployment: install full archive, clean temp dirs, health binary probe#3

Merged
lmangani merged 2 commits intomainfrom
copilot/fix-prebuilt-installation-deployment
Mar 21, 2026
Merged

Fix prebuilt deployment: install full archive, clean temp dirs, health binary probe#3
lmangani merged 2 commits intomainfrom
copilot/fix-prebuilt-installation-deployment

Conversation

Copy link
Contributor

Copilot AI commented Mar 21, 2026

The bundle-acestep.ts script only deployed ace-lm and ace-synth, discarding all shared libraries (libggml*.so/.dylib/.dll) and helper binaries required at runtime. Temp job directories were also not fully cleaned up, and /health had no actual binary verification.

Changes

  • scripts/bundle-acestep.ts — Copy every file from the extracted archive to acestep-runtime/bin/ instead of cherry-picking two executables. The archives contain 20+ files: ace-server, ace-understand, neural-codec, mp3-codec, quantize, and all GGML shared libraries. chmod 0o755 applied to all non-.a files on non-Windows.

  • src/worker.ts — Replace the readdir + per-file unlink loop in finally with rm(jobDir, { recursive: true, force: true }). The old approach left the job directory itself on disk and silently missed any subdirectories (e.g. uploaded audio).

  • src/index.ts/health now spawns ace-synth with no arguments (prints usage, exits non-zero — expected) to confirm the binary is present and executable:

    {
      "status": "ok",
      "binary": "ok",
      "binary_path": "/…/acestep-runtime/bin/ace-synth",
      "binary_hint": "Usage: ace-synth --request <json...> …"
    }

    Returns "binary": "unavailable" with an error hint when the binary is missing or fails to start.

  • README.md / docs/API.md — Updated distribution tree and health response docs to reflect the above.


⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

Copilot AI changed the title [WIP] Fix pre-built installation to deploy full content of acestep-cpp Fix prebuilt deployment: install full archive, clean temp dirs, health binary probe Mar 21, 2026
Copilot AI requested a review from lmangani March 21, 2026 11:34
@lmangani lmangani marked this pull request as ready for review March 21, 2026 11:55
@lmangani lmangani merged commit 987bf51 into main Mar 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants