Skip to content

Rename --model → --lm and --text-encoder → --embedding in ace-* CLI invocations#25

Merged
lmangani merged 2 commits intomainfrom
copilot/rename-parameters-in-acestep-tools
Mar 18, 2026
Merged

Rename --model → --lm and --text-encoder → --embedding in ace-* CLI invocations#25
lmangani merged 2 commits intomainfrom
copilot/rename-parameters-in-acestep-tools

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

Upstream acestep-cpp binaries changed two CLI parameter names that must be reflected in all ace-* tool invocations.

Changes

  • server/src/services/acestep.ts
    • ace-lm call: --model--lm
    • ace-dit call: --text-encoder--embedding
    • ace-understand call: --model--lm
  • server/src/routes/generate.ts
    • ace-lm (lyrics-to-tags): --model--lm

The --model flag in referenceTrack.ts (Whisper transcription) is unrelated and left unchanged.

// Before
['--request', requestPath, '--model', lmModel]
['--text-encoder', textEncoderModel, ...]

// After
['--request', requestPath, '--lm', lmModel]
['--embedding', textEncoderModel, ...]

Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot AI changed the title [WIP] Update parameters for acestep tools invocations Rename --model → --lm and --text-encoder → --embedding in ace-* CLI invocations Mar 18, 2026
Copilot AI requested a review from lmangani March 18, 2026 18:24
@lmangani lmangani marked this pull request as ready for review March 18, 2026 19:22
@lmangani lmangani merged commit 1920297 into main Mar 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants