Allow the generalization of non-overloaded simple local binds#414
Open
arossato wants to merge 2 commits intoaugustss:masterfrom
Open
Allow the generalization of non-overloaded simple local binds#414arossato wants to merge 2 commits intoaugustss:masterfrom
arossato wants to merge 2 commits intoaugustss:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the second commit
mhswill generalize non-overloaded simple binds like:I've already illustrated the reason of this proposal in a post, #413, in the discussion section.
This is going, obviously, to affect performance, in some ways. Taking the
mhscode base as a reference, the calls togetMetaTyVarswill increase from ~384 to ~1745, even though only ~68 will require the subsequent expensive test for type variables in the environment.The recompilation time:
Recompiling with
mhsdoesn't change the numbers significantly, but I'm ashamed to show the numbers I get on my old laptop... ;-)The first commit is a fix to a quite unnoticeable bug in
tcBindGpr': the state is captured after new unification variables are created for the bind's identifiers. While these are nonetheless inserted into the environment, they get skipped by thenull qvscheck, which checks for meta variables created after the state was captured.After applying the second commit, though, the bug would be visible in some corner cases in which a bind wouldn't be generalized even if expected, like: