Fix adjustableRunTIme bug in the FoamTimeStepper - #123
Merged
mattfalcone1997 merged 9 commits intoJul 13, 2026
Merged
Conversation
k-collie
reviewed
Jul 10, 2026
k-collie
left a comment
k-collie
left a comment
Collaborator
There was a problem hiding this comment.
First set of comments, looks good so far
k-collie
reviewed
Jul 13, 2026
Co-authored-by: k-collie <101559596+k-collie@users.noreply.github.com>
k-collie
approved these changes
Jul 13, 2026
k-collie
left a comment
k-collie
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me!
Maybe squash merge when you merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
mooseDeltaTfunction object is searfched in Foam::Time rather than a reference stored and it is now recreated if it is cleared byFoam::Time::adjustDeltaTRelated Issue
Resolves #122
Checklist