Skip to content

Fix: await async jwt.verify function#320

Merged
jfromaniello merged 1 commit into
auth0:masterfrom
glensc:patch-1
Feb 6, 2023
Merged

Fix: await async jwt.verify function#320
jfromaniello merged 1 commit into
auth0:masterfrom
glensc:patch-1

Conversation

@glensc

@glensc glensc commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This looks like bug, to be able to try/catch exception from async function, it must be awaited.

Checklist

  • This change adds test coverage for new/changed/fixed functionality
  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@glensc

glensc commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

The correct base branch is being used, if not the default branch

unclear what this refers to. git branch? I see only master, also no contributing.md in this repo and the org wide file doesn't have details either.

@glensc glensc changed the title Fix: Await async jwt.verify function Fix: await async jwt.verify function Feb 6, 2023
@jfromaniello
jfromaniello merged commit d1e88c7 into auth0:master Feb 6, 2023
@jfromaniello

Copy link
Copy Markdown
Contributor

Make sense, published as v8.4.1

@glensc
glensc deleted the patch-1 branch February 6, 2023 17:09
@glensc

glensc commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

@glensc

glensc commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants