test: address flake in HeadRevisionDoesNotConsumeXID#3163
Merged
Conversation
github-actions
Bot
added
area/datastore
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: ea8450c | Previous: f1ae3b8 | Ratio |
|---|---|---|---|
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) |
34167382 ns/op 174789 B/op 20200 allocs/op |
7776957 ns/op 172930 B/op 20196 allocs/op |
4.39 |
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
34167382 ns/op |
7776957 ns/op |
4.39 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) |
33394895 ns/op 173775 B/op 20199 allocs/op |
7562874 ns/op 172825 B/op 20195 allocs/op |
4.42 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
33394895 ns/op |
7562874 ns/op |
4.42 |
This comment was automatically generated by workflow using github-action-benchmark.
tstirrat15
force-pushed
the
tstirrat/remove-flaking-xid-test
branch
2 times, most recently
from
ef492e5 to
70a95ec
Compare
miparnisari
reviewed
Jun 9, 2026
| after := nextXID() | ||
|
|
||
| require.Equal(t, before, after, "HeadRevision burned %d xid(s) over %d calls; expected 0", after-before, iterations) | ||
| // NOTE: we're expecting <= 1 here because there's a heartbeat goroutine that increments |
Contributor
There was a problem hiding this comment.
before we do this relaxation, can we try something else? add cmd = append(cmd, "-c", "autovacuum=off") in line 66 inside RunPostgresForTestingWithCommitTimestamps. I assume that none of the existing tests depend on this vacuum process (@josephschorr ?)
my suspicion is that the vacuum processing is what is burning this extra XID.
Member
There was a problem hiding this comment.
Let's try it - see if it does remove the flake
miparnisari
changed the title
tstirrat15
force-pushed
the
tstirrat/remove-flaking-xid-test
branch
from
70a95ec to
b665427
Compare
tstirrat15
force-pushed
the
tstirrat/remove-flaking-xid-test
branch
from
b665427 to
ea8450c
Compare
github-actions
Bot
removed
area/datastore
miparnisari
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This test has been flaking: https://github.com/authzed/spicedb/actions/runs/27164166509/job/80187393099?pr=3154
Relaxing the assertion slightly should help.
Changes
Testing
Review.