test(certtest): make TestCertRotation actually verify hot cert reload#3169
Merged
miparnisari merged 1 commit intoJun 11, 2026
Merged
Conversation
github-actions
Bot
added
the
area/tooling
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The old test reused a single connection post-rotation; TLS never renegotiates, so it passed even with updateCachedCertificate disabled. Rewrite uses VerifyConnection on fresh per-dial ClientConns to assert the server presents the rotated certificate serial after reload.
miparnisari
force-pushed
the
fix/issue-3164-cert-rotation-test
branch
from
7cd4405 to
c43fb70
Compare
miparnisari
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TestCertRotationpassed even withupdateCachedCertificatedisabled: itreused a single connection for all post-rotation requests, and TLS never
renegotiates mid-connection, so the test could never observe whether the
server was presenting the rotated cert.
Rewrite uses
VerifyConnectionon fresh per-dialClientConns to assertthe server presents the rotated certificate serial after reload.
Closes #3164