test: add more goleak checks#3175
Merged
Merged
Conversation
github-actions
Bot
added
area/api v1
miparnisari
force-pushed
the
test-add-goleak
branch
from
03b8772 to
d1b1f92
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
miparnisari
force-pushed
the
test-add-goleak
branch
from
d1b1f92 to
945ca99
Compare
miparnisari
force-pushed
the
test-add-goleak
branch
3 times, most recently
from
fa26ccf to
c254ae1
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…defaults Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
miparnisari
force-pushed
the
test-add-goleak
branch
from
c254ae1 to
b171f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #3171 since there are more goroutine leaks.
I am pretty sure that the leak is that we made telemetry ON by default
https://github.com/authzed/spicedb/blame/87482ed4fbeabd57ae4e896e1b4674958e6b16ba/pkg/cmd/server/server.go#L162
and now we are leaking its connection. The fix is in
internal/telemetry/reporter.go.