PUR1-3530: Update php-app-logger to monolog/monolog 3#20
Open
i-pidhorodetskyi wants to merge 1 commit into
Open
PUR1-3530: Update php-app-logger to monolog/monolog 3#20i-pidhorodetskyi wants to merge 1 commit into
i-pidhorodetskyi wants to merge 1 commit into
Conversation
i-pidhorodetskyi
force-pushed
the
PUR1-3530-monolog-upgrade
branch
from
f69a2da to
78d2178
Compare
diego1auto
reviewed
Jul 7, 2026
| * @return $this | ||
| */ | ||
| public function setLogger(LoggerInterface $logger) | ||
| public function setLogger(LoggerInterface $logger): void |
Contributor
There was a problem hiding this comment.
this will require a major version update
| * @var NameConverterInterface | ||
| */ | ||
| private $nameConverter; | ||
| private NameConverterInterface $nameConverter; |
Contributor
There was a problem hiding this comment.
then lets drop support for version 4 and just have symfony/serializer: ~5.0|~6.0|~7.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.