Typescript bindings#75
Closed
euforic wants to merge 3 commits intoautonomoussoftware:masterfrom
euforic:typescript-bindings
Closed
Typescript bindings#75euforic wants to merge 3 commits intoautonomoussoftware:masterfrom euforic:typescript-bindings
euforic wants to merge 3 commits intoautonomoussoftware:masterfrom
euforic:typescript-bindings
Conversation
- Add command to package.json to generate go bindings - Generate Go bindings
|
Big +1 on making sure you use local bins in package.json. I have no opinion on the typescript stuff itself. Not sure about bumping the allowed nodejs version. @gabmontes should probably comment on that. |
Author
|
@jcvernaleo yeah in order to get the typescript bindings to generate I had to bump the version of node. You can diff the compile with the two different versions of node I'm pretty sure they are identical. |
|
It occurs to me that if you need a newer nodejs maybe it should also be updated in the |
- Add typescript contract binding generation - Update package.json with generation script - Update package.json to use local bins to ensure consistent versions - Add eslintignore to ignore generated typescript code - Bump Node.js / NPM version - Update travis Node.js version
Author
|
@jcvernaleo updated travis and commit notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one might not be as needed, but I figured it would be nice to have an official js API binding too
Note
Please merge #74 -> #73 and then this PR