Skip to content

Handle errors during getLinks parsing#34

Merged
lkmgr merged 1 commit intomainfrom
improve-html-parsing-error-handling
Oct 30, 2025
Merged

Handle errors during getLinks parsing#34
lkmgr merged 1 commit intomainfrom
improve-html-parsing-error-handling

Conversation

@lkmgr
Copy link
Collaborator

@lkmgr lkmgr commented Oct 30, 2025

In some cases, DOMException [TimeoutError]: The operation was aborted due to timeout is shown and crashes the process. This seems to originate from the link parsing in getLinks.

  • add error handler to the Readable stream to reject the promise
  • catch error during getLinks parsing and treat it as a broken link

@lkmgr lkmgr self-assigned this Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.62%. Comparing base (ff63e70) to head (a1c13d9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   93.55%   93.62%   +0.06%     
==========================================
  Files          10       10              
  Lines        1024     1035      +11     
  Branches      282      287       +5     
==========================================
+ Hits          958      969      +11     
  Misses         65       65              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkmgr lkmgr force-pushed the improve-html-parsing-error-handling branch from 0e5a269 to eb43a52 Compare October 30, 2025 11:39
@lkmgr lkmgr force-pushed the improve-html-parsing-error-handling branch from eb43a52 to a1c13d9 Compare October 30, 2025 12:22
@StefanSchwartze StefanSchwartze self-requested a review October 30, 2025 12:41
@lkmgr lkmgr merged commit 39ca01c into main Oct 30, 2025
8 of 9 checks passed
@lkmgr lkmgr deleted the improve-html-parsing-error-handling branch October 30, 2025 12:47
@github-actions
Copy link

🎉 This PR is included in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants