Allow the _ character in property names #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! I just returned from vacation, and plan to have a look at this very soon |
Owner
|
Merged, thanks again! Note: My fork was not planned to be maintained, and I might at some point clean up the commit history, especially if [1] is merged. For now, it would probably be safest to not let anything point to this fork's master and use your own fork or a commit hash instead [1] nilclass#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Org archiving, and it adds a property
ARCHIVE_DATEwhen I archive an entry. This was not being parsed properly. Simple fix I think. Added test support as well.