LIBRARIES-1638 - Add x-queue-type support and drop lazy support (now unsupported by rabbit) by fegbers · Pull Request #19 · avides/spring-rabbit

fegbers · 2026-07-01T07:58:15Z

Breaking Change: Starting with this version, the quorum queues are the new default => The queue declaration changes, so the queues must be recreated when the version number is incremented. In addition, “Lazy” support has been removed, since Rabbit is also removing it.

github-actions · 2026-07-01T07:59:35Z

Documentation added or updated?
- Diff-Links as response added?
  - Not necessary
  - Added
Breaking-Change present?
- Necessary deployment adjustments added as a comment (Ticket)?
  - Not necessary
  - Added
- Necessary rollback adjustments added as a comment (Ticket)?
  - Not necessary
  - Added

Copilot

Pull request overview

This PR updates queue declaration behavior to support the x-queue-type argument and removes the previous “lazy queue mode” usage, aligning tests and example configurations accordingly. It also bumps the project version to 3.0.0-RC1 and updates a test dependency.

Changes:

Add x-queue-type handling to queue/DLX queue creation and update tests to assert the new argument.
Update test application property sets to use arguments[x-queue-type] and remove x-queue-mode/queue-mode usage.
Bump project version to 3.0.0-RC1 and update springtainer-rabbitmq version.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/main/java/com/avides/spring/rabbit/configuration/creator/QueueCreator.java	Adds `x-queue-type` constants and injects a default queue type into queue arguments.
src/main/java/com/avides/spring/rabbit/configuration/creator/DlxQueueCreator.java	Replaces `x-queue-mode=lazy` with `x-queue-type` resolution for DLX queues.
src/test/resources/application-queueManagementWithOneConnectionFactory.properties	Removes lazy config and adds `arguments[x-queue-type]=classic` for queue one.
src/test/resources/application-multipleConnectionFactories.properties	Fixes routing key index and adds `arguments[x-queue-type]=classic`; removes lazy arg.
src/test/java/com/avides/spring/rabbit/configuration/SpringRabbitAutoConfigurationForQueueManagementWithOneConnectionFactoryIT.java	Updates assertions for `x-queue-type` and argument counts.
src/test/java/com/avides/spring/rabbit/configuration/SpringRabbitAutoConfigurationForMultipleConnectionFactoriesIT.java	Updates assertions for `x-queue-type` and removes lazy expectations.
src/test/java/com/avides/spring/rabbit/configuration/creator/QueueCreatorTest.java	Updates expected argument map and adds an override test for queue type.
src/test/java/com/avides/spring/rabbit/configuration/creator/DlxQueueCreatorTest.java	Updates expected DLX args and adds an override test for queue type.
README.md	Updates the documented dependency version to `3.0.0-RC1`.
pom.xml	Bumps project version, adds a developer entry, and updates `springtainer-rabbitmq` version.

Comments suppressed due to low confidence (1)

src/main/java/com/avides/spring/rabbit/configuration/creator/QueueCreator.java:53

Defaulting x-queue-type to "quorum" for all queues can produce invalid declarations when users configure non-quorum-compatible flags (e.g., durable=false or exclusive=true). RabbitMQ rejects quorum queues that are non-durable and/or exclusive, so this can turn previously-valid configurations into runtime failures unless users explicitly set x-queue-type=classic.

    private Map<String, Object> createArguments()
    {
        Map<String, Object> arguments = new HashMap<>(queueProperties.getArguments());
        arguments.putIfAbsent(X_QUEUE_TYPE, DEFAULT_X_QUEUE_TYPE);
        arguments.put("x-dead-letter-exchange", "");
        arguments.put("x-dead-letter-routing-key", queueProperties.getName() + ".dlx");
        arguments.put("x-max-length", Long.valueOf(queueProperties.getLimit()));
        return arguments;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fegbers · 2026-07-01T08:24:29Z

+    private String resolveQueueType()
+    {
+        if (queueProperties.getArguments() != null && queueProperties.getArguments().get(X_QUEUE_TYPE) != null)
+        {
+            return (String) queueProperties.getArguments().get(X_QUEUE_TYPE);
+        }
+        return DEFAULT_X_QUEUE_TYPE;
+    }


It has to fail quickly, and we don't want to implement the “Rabbit” logic twice.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

fegbers · 2026-07-01T08:24:57Z

+        Map<String, Object> arguments = new HashMap<>(queueProperties.getArguments());
+        arguments.putIfAbsent(X_QUEUE_TYPE, DEFAULT_X_QUEUE_TYPE);
        arguments.put("x-dead-letter-exchange", "");
        arguments.put("x-dead-letter-routing-key", queueProperties.getName() + ".dlx");
        arguments.put("x-max-length", Long.valueOf(queueProperties.getLimit()));


It has to fail quickly, and we don't want to implement the “Rabbit” logic twice.

fegbers · 2026-07-01T08:24:44Z

+    private String resolveQueueType()
+    {
+        if (queueProperties.getArguments() != null && queueProperties.getArguments().get(X_QUEUE_TYPE) != null)
+        {
+            return (String) queueProperties.getArguments().get(X_QUEUE_TYPE);
+        }
+        return DEFAULT_X_QUEUE_TYPE;
+    }


It has to fail quickly, and we don't want to implement the “Rabbit” logic twice.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

+        Map<String, Object> arguments = new HashMap<>(queueProperties.getArguments());
+        arguments.putIfAbsent(X_QUEUE_TYPE, DEFAULT_X_QUEUE_TYPE);


Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/release.yml:9

The release workflow is configured to run only on pushes to the feature branch LIBRARIES-1638, while the inline comment says it should run on the master branch. As written, releases won’t trigger from master (and could trigger unexpectedly from that feature branch).

on:
  push:
    branches:
      # Runs only on push to the master branch
      - master

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

    private Map<String, Object> createArguments()
    {
-        Map<String, Object> arguments = queueProperties.getArguments();
+        Map<String, Object> arguments = new HashMap<>(queueProperties.getArguments());


+          java-version: ${{ steps.determine_java_version.outputs.detected_java_version }}
+          server-id: central
+          server-username: OS_CENTRAL_USERNAME
+          server-password: OS_CENTRAL_PASSWORD


Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

+      # Check if reminder comment is already given
+      - name: find-reminder-comment
+        uses: peter-evans/find-comment@v4
+        id: find_reminder_comment
        with:
          issue-number: ${{ github.event.number }}
          body-includes: "Confluence/GitHub documentation added or updated?"



github-advanced-security · 2026-07-10T09:58:05Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

+      # Get the current project version from pom.xml
+      - name: get-project-version
+        id: get_project_version
+        uses: avides/actions-project-version-check@v2


+      # Get the current project version from pom.xml
+      - name: get-project-version
+        id: get_project_version
+        uses: avides/actions-project-version-check@v2


-        continue-on-error: true
-        env:
-          GITHUB_TOKEN: ${{ secrets.GPR_TOKEN }}
+        uses: softprops/action-gh-release@v2


      # Verify project version is updated
      - name: project-version-check
-        uses: avides/actions-project-version-check@v1
+        uses: avides/actions-project-version-check@v2


+
+      # Check if reminder comment is already given
+      - name: find-reminder-comment
+        uses: peter-evans/find-comment@v4


-            -Dsonar.login=${SONAR_TOKEN} \
+          mvn org.sonarsource.scanner.maven:sonar-maven-plugin:5.5.0.6356:sonar \
+            -Dsonar.host.url=${{ secrets.OS_SONAR_HOST_URL }} \
+            -Dsonar.token=${{ secrets.OS_SONAR_TOKEN }} \


-            -Dsonar.host.url=${SONAR_HOST} \
-            -Dsonar.login=${SONAR_TOKEN} \
+          mvn org.sonarsource.scanner.maven:sonar-maven-plugin:5.5.0.6356:sonar \
+            -Dsonar.host.url=${{ secrets.OS_SONAR_HOST_URL }} \


-            -Dsonar.login=${SONAR_TOKEN} \
+          mvn org.sonarsource.scanner.maven:sonar-maven-plugin:5.5.0.6356:sonar \
+            -Dsonar.host.url=${{ secrets.OS_SONAR_HOST_URL }} \
+            -Dsonar.token=${{ secrets.OS_SONAR_TOKEN }} \


-            -Dsonar.projectKey=${GITHUB_REPOSITORY//\//_} \
-            -Dsonar.pullrequest.key=${{ github.event.number }} \
+          mvn org.sonarsource.scanner.maven:sonar-maven-plugin:5.5.0.6356:sonar \
+            -Dsonar.host.url=${{ secrets.OS_SONAR_HOST_URL }} \


Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

-            -Dsonar.pullrequest.key=${{ github.event.number }} \
+          mvn org.sonarsource.scanner.maven:sonar-maven-plugin:5.5.0.6356:sonar \
+            -Dsonar.host.url=${{ secrets.OS_SONAR_HOST_URL }} \
+            -Dsonar.token=${{ secrets.OS_SONAR_TOKEN }} \


…git into LIBRARIES-1638

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

sonarqubecloud · 2026-07-10T11:18:26Z

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

      # Update GitHub Action configuration if necessary
      - name: action-configuration-autoupdate
-        uses: avides/actions-action-configuration-autoupdate@v1
+        uses: avides/actions-action-configuration-autoupdate@v2



      # Push updated GitHub Actions configuration if necessary
-      - uses: stefanzweifel/git-auto-commit-action@v4
+      - uses: stefanzweifel/git-auto-commit-action@v7


LIBRARIES-1638 - Add x-queue-type support

7f2e6d5

Copilot AI review requested due to automatic review settings July 1, 2026 07:58

Copilot started reviewing on behalf of fegbers July 1, 2026 07:58 View session

fixes

99d6c2e

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 1, 2026 08:02

Copilot started reviewing on behalf of fegbers July 1, 2026 08:02 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Apply suggestions from code review

3bb5e39

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 1, 2026 08:25

Copilot started reviewing on behalf of fegbers July 1, 2026 08:25 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread .github/workflows/nightly.yml Outdated

fegbers and others added 2 commits July 1, 2026 10:37

RC build

de2b76e

Update GitHub Action configuration

1b520a8

Copilot AI review requested due to automatic review settings July 1, 2026 08:37

Copilot started reviewing on behalf of avides-builds July 1, 2026 08:37 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread .github/workflows/review.yml

fegbers and others added 2 commits July 2, 2026 23:59

fixes

4364457

Update GitHub Action configuration

8536874

Copilot AI review requested due to automatic review settings July 2, 2026 22:00

Copilot started reviewing on behalf of avides-builds July 2, 2026 22:00 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread src/main/java/com/avides/spring/rabbit/configuration/creator/QueueCreator.java

Comment on lines +48 to +49

Map<String, Object> arguments = new HashMap<>(queueProperties.getArguments());

arguments.putIfAbsent(X_QUEUE_TYPE, DEFAULT_X_QUEUE_TYPE);

fegbers added 2 commits July 3, 2026 00:18

fix

7376190

RC build

06ad471

Copilot AI review requested due to automatic review settings July 2, 2026 22:18

Copilot started reviewing on behalf of fegbers July 2, 2026 22:19 View session

Update GitHub Action configuration

02d000c

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread pom.xml Outdated

Copilot AI review requested due to automatic review settings July 2, 2026 22:21

avides deleted a comment from github-actions Bot Jul 3, 2026

Copilot AI reviewed Jul 3, 2026

View reviewed changes

fegbers mentioned this pull request Jul 10, 2026

Lazy-Queue-Mode is discontinued / the new default (RabbitMQ 3.12.X) #17

Closed

new RC to fix sonarcloud connection

b1c39ef

Copilot AI review requested due to automatic review settings July 10, 2026 09:54

Copilot started reviewing on behalf of fegbers July 10, 2026 09:54 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

github-advanced-security AI found potential problems Jul 10, 2026

View reviewed changes

release

b77ae16

Copilot AI review requested due to automatic review settings July 10, 2026 11:03

Update GitHub Action configuration

d3c8ced

Copilot started reviewing on behalf of fegbers July 10, 2026 11:03 View session

avides deleted a comment from github-actions Bot Jul 10, 2026

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/review.yml

avides deleted a comment from github-actions Bot Jul 10, 2026

github-advanced-security AI found potential problems Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/review.yml

-Dsonar.pullrequest.key=${{ github.event.number }} \

mvn org.sonarsource.scanner.maven:sonar-maven-plugin:5.5.0.6356:sonar \

-Dsonar.host.url=${{ secrets.OS_SONAR_HOST_URL }} \

-Dsonar.token=${{ secrets.OS_SONAR_TOKEN }} \

avides deleted a comment from github-actions Bot Jul 10, 2026

fegbers added 2 commits July 10, 2026 13:14

fixes

61b1f88

Merge branch 'LIBRARIES-1638' of git@github.com:avides/spring-rabbit.…

0833f40

…git into LIBRARIES-1638

Copilot AI review requested due to automatic review settings July 10, 2026 11:14

Update GitHub Action configuration

661a81f

Copilot started reviewing on behalf of fegbers July 10, 2026 11:14 View session

avides deleted a comment from github-actions Bot Jul 10, 2026

Copilot AI reviewed Jul 10, 2026

View reviewed changes

github-advanced-security AI found potential problems Jul 10, 2026

View reviewed changes

fegbers requested review from julian-eggers and sdaus July 10, 2026 11:19

		Map<String, Object> arguments = new HashMap<>(queueProperties.getArguments());
		arguments.putIfAbsent(X_QUEUE_TYPE, DEFAULT_X_QUEUE_TYPE);

Uh oh!

Conversation

fegbers commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited by fegbers Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

fegbers Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

fegbers Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

fegbers Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-advanced-security AI commented Jul 10, 2026

What Enabling Code Scanning Means:

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sonarqubecloud Bot commented Jul 10, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

fegbers commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited by fegbers

Loading