feat(wake): add amq wake retire for identity-safe inject-via stop - #256
Merged
Conversation
Merged
avivsinai
added a commit
that referenced
this pull request
Jul 21, 2026
🤖 I have created a release *beep* *boop* --- ## [0.45.0](v0.44.0...v0.45.0) (2026-07-21) ### Features * **fsq:** fd-confined message delivery via os.Root capability ([#257](#257)) ([059a076](059a076)) * **wake:** add amq wake retire for identity-safe inject-via stop ([#256](#256)) ([a57dba9](a57dba9)) * **wake:** Darwin cooperative unix-socket shutdown for inject-via wakes ([#254](#254)) ([6d66a20](6d66a20)) ### Bug Fixes * **delivery:** report indeterminate-durability commits + capability-relative reads ([#261](#261)) ([63cc42f](63cc42f)) * **wake:** close cooperative-stop duplicate-injection window and harden Darwin lifecycle ([#260](#260)) ([8d6e6f4](8d6e6f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jul 21, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 6 of #235 — reintroduces
amq wake retireon the identity-safe primitives now in place (deferred out of #232 until the signal-safety work landed). Retires only an identity-confirmed live inject-via wake whose saved target exactly matches the expected--inject-via+ ordered--inject-arg, using the W4 Linux-pidfd / W5b Darwin-cooperative stop — never bare-PID — or removes an exactly-bound proven-stale lock. Preserves the mailbox and saved target. Structuredretired/refused/erroroutput (JSON + text).Boundary (documented in CLAUDE.md/README)
repair= replace a proven-stale inject-via wakedoctor --fix-wake-locks= remove a proven-stale lockretire= stop an identity-confirmed live inject-via wakeFail-closed refusals
Missing lock (absence unprovable), raw wake, unconfirmed identity, unverified/creating lock, missing saved target, and any injector path/argv mismatch all refuse. The stop path runs under the lifecycle guard for validation and releases it for the actual cooperative/pidfd stop.
Review
amq wake retiredispatch runtime-verified (runWake→case "retire"→runWakeRetire; executes, not the generic loop — closing the exact gap #245's keepalive hit). Tests: Darwin cooperative retire + target preservation, Linux pidfd retire (CI-only), raw refusal, exact-target-mismatch refusal, proven-stale removal, missing-target refusal, JSON+text output.make ci(incl golangci-lint 0 issues) + all four GOOS builds green.Part of #235. Implementation by Codex; design/review by Claude.
🤖 Generated with Claude Code