Skip to content

fix(ci): skip release-please on release-commit pushes to avoid tag race - #271

Merged
avivsinai merged 1 commit into
mainfrom
codex/fix-release-please-tag-race
Jul 23, 2026
Merged

fix(ci): skip release-please on release-commit pushes to avoid tag race#271
avivsinai merged 1 commit into
mainfrom
codex/fix-release-please-tag-race

Conversation

@avivsinai

Copy link
Copy Markdown
Owner

Summary

  • skip the Release Please job on squash release-commit pushes while preserving manual dispatch
  • pin the guard in the existing release-please safety-contract test
  • prevent the tag-creation race that produced the spurious v0.47.0 release PR chore(release): v0.47.0 #269

Root cause

release-please.yml and release.yml both run on the merged release commit. The Release Please run can scan before release.yml creates the new tag, conclude that no latest release exists, and backfill repository history into a bogus next release PR.

Release Please is PR-only here (skip-github-release: true), so it has no work to perform on the release commit itself. The next conventional commit runs after the tag exists; workflow_dispatch remains available for manual recovery.

Accepted residual

If a feature reaches main after Release Please last updated the release PR but before that release PR merges, skipping the release-commit push means the feature waits for the next main commit or a manual dispatch before appearing in the next release PR. This fails quiet and self-heals; it replaces the current behavior of generating a history-replay release PR.

Verification

  • python3 scripts/test_release_please_config.py
  • yamllint -d '{extends: relaxed, rules: {line-length: disable, truthy: disable}}' .github/workflows/release-please.yml
  • go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/release-please.yml
  • git diff --check
  • make ci

Peer-reviewed by Claude before commit; PASS with the accepted residual above called out explicitly.

@avivsinai
avivsinai merged commit e37067a into main Jul 23, 2026
5 checks passed
@avivsinai
avivsinai deleted the codex/fix-release-please-tag-race branch July 23, 2026 18:52
avivsinai added a commit that referenced this pull request Jul 24, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.47.0](v0.46.0...v0.47.0)
(2026-07-24)


### Features

* **wake:** add identity-safe owner-bound lifecycle
([#277](#277))
([84ea950](84ea950))


### Bug Fixes

* **ci:** skip release-please on release-commit pushes to avoid tag race
([#271](#271))
([e37067a](e37067a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant