Allow exception details when sending error#122
Open
nirizr wants to merge 1 commit intoavoylenko:mainfrom
Open
Conversation
This change allows calling sendErrorResponse with an exception (instead of a string) to include exception details within the returned error. This helps in debugging issues, while currently keeping the existing behavior with no change. Ideally replacing message in calls to sendErrorResponse with the exception object will make error responses easier to understand. Exposing the additional details may be a bit insecure, so it's smarted to control with a debug flag.
Owner
|
This implementation leaks internal data to the world. Full data captured by pino and a service owner is able to provide it per request. Sorry, i can't give the PR a go. |
Contributor
Author
|
Thanks for taking your time. I'm fully aware of the internal info exposed (as mentioned in my last sentence). If there's a builtin way to get the entire trace for an exception i'd gladly use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows calling sendErrorResponse with an exception (instead of a string) to include exception details within the returned error. This helps in debugging issues, while currently keeping the existing behavior with no change.
Ideally replacing message in calls to sendErrorResponse with the exception object will make error responses easier to understand.
Exposing the additional details may be a bit insecure, so it's smarted to control with a debug flag.