Add YAML parameter support and event streaming #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Native YAML object/array support for parameters and tags - Real-time CloudFormation event streaming during deployments - Retry logic with exponential backoff for API throttling - Enhanced parameter parsing with multiple format support Based on PR aws-actions#152
kddejong
force-pushed
the
feature/yaml-params-event-streaming
branch
2 times, most recently
from
0606a5d to
7909a8b
Compare
Co-authored-by: Erik Günther <egut@users.noreply.github.com>
- Add event-streaming-coverage.test.ts (1061 lines) - Add fast-check dependency for property testing - Fix ThrottlingException mocks - Add core.warning to jest setup - Skip property tests temporarily (integration issues) Coverage improved from 63% to 93% Co-authored-by: Erik Günther <egut@users.noreply.github.com>
kddejong
force-pushed
the
feature/yaml-params-event-streaming
branch
from
bb5a483 to
a80a443
Compare
- Use DescribeEventsCommand with ChangeSetName for precise event tracking - Only get events for the specific change set operation - Update EventMonitorConfig to accept changeSetName - Update all test mocks to use OperationEvents instead of StackEvents - Maintains 93% test coverage This provides more accurate event filtering by tracking only the current deployment operation instead of all historical stack events. Co-authored-by: Erik Günther <egut@users.noreply.github.com>
Display additional OperationEvent fields for better debugging: - EventType (VALIDATION_ERROR, PROVISIONING_ERROR, HOOK_INVOCATION_ERROR, etc.) - DetailedStatus (CONFIGURATION_COMPLETE, VALIDATION_FAILED) - Hook information (type, status, failure mode, invocation point) - Validation information (name, failure mode) - Operation information (type, status) Example output: [VALIDATION_ERROR] AWS::Lambda::Function/MyFunc CREATE_FAILED (VALIDATION_FAILED) [Validation: PermissionCheck (FAIL)] ERROR: Insufficient permissions This provides comprehensive visibility into all CloudFormation operation events including hooks, validations, and detailed error context. Co-authored-by: Erik Günther <egut@users.noreply.github.com>
- Test validation error event formatting - Test hook invocation error formatting - Test operation information display - Test event type filtering (STACK_EVENT vs others) - Coverage improved from 89.86% to 94.05% Co-authored-by: Erik Günther <egut@users.noreply.github.com>
CloudFormation API uses error.name === 'Throttling' (not 'ThrottlingException') with message 'Rate exceeded' and HTTP status 400. Updated throttling detection to check for: - 'Throttling' (CloudFormation standard) - 'ThrottlingException' (other AWS services) - 'TooManyRequestsException' (fallback) - Message contains 'Rate exceeded' Added test for CloudFormation-specific Throttling error name. Co-authored-by: Erik Günther <egut@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @egut's work in #152
Key Changes
parameter-overridesandtagsinputssrc/event-streaming.ts)What was excluded from PR #152
Credit
Original implementation by @egut in #152. This PR extracts the core functionality changes while maintaining cleaner integration with the develop branch.
Testing Needed