First commit after repackage and removal of build/ which included AWS…#40
First commit after repackage and removal of build/ which included AWS…#40skellish-aws wants to merge 1 commit intoaws-cloudformation:mainfrom
Conversation
mrinaudo-aws
left a comment
mrinaudo-aws
left a comment
There was a problem hiding this comment.
Thank you, @skellish-aws - I left initial feedback for my first review. Can you please implement contract test inputs, and make sure contract tests pass? Please also address the initial feedback I shared. Thank you!
| { | ||
| "artifact_type": "HOOK", | ||
| "typeName": "AWSSamples::Ec2SsmSmOnly::Hook", | ||
| "language": "python36", |
There was a problem hiding this comment.
This should be python37 at least.
| "artifact_type": "HOOK", | ||
| "typeName": "AWSSamples::Ec2SsmSmOnly::Hook", | ||
| "language": "python36", | ||
| "runtime": "python3.6", |
There was a problem hiding this comment.
This should be python3.7 at least.
| { | ||
| "typeName": "AWSSamples::Ec2SsmSmOnly::Hook", | ||
| "description": "Checks that EC2 instances being deployed are configured to only allow use of SSM Session Manager to access the instance", | ||
| "sourceUrl": "https://github.com/aws-cloudformation/example-sse-hook", |
There was a problem hiding this comment.
Please update the URL accordingly.
| "typeName": "AWSSamples::Ec2SsmSmOnly::Hook", | ||
| "description": "Checks that EC2 instances being deployed are configured to only allow use of SSM Session Manager to access the instance", | ||
| "sourceUrl": "https://github.com/aws-cloudformation/example-sse-hook", | ||
| "documentationUrl": "https://github.com/aws-cloudformation/example-sse-hook/blob/master/README.md", |
There was a problem hiding this comment.
Please update the URL accordingly.
| @@ -0,0 +1 @@ | |||
| cloudformation-cli-python-lib==2.2.hooks | |||
There was a problem hiding this comment.
This should be cloudformation-cli-python-lib>=2.1.9 at least.
| @@ -0,0 +1,32 @@ | |||
| AWSTemplateFormatVersion: "2010-09-09" | |||
There was a problem hiding this comment.
This file does not seem to be needed - please remove it, or clarify.
| Type: AWS::Serverless::Function | ||
| Properties: | ||
| Handler: awssamples_ec2ssmsmonly_hook.handlers.hook | ||
| Runtime: python3.6 |
There was a problem hiding this comment.
Please update the runtime version here as well.
| Type: AWS::Serverless::Function | ||
| Properties: | ||
| Handler: awssamples_ec2ssmsmonly_hook.handlers.test_entrypoint | ||
| Runtime: python3.6 |
There was a problem hiding this comment.
Please update the runtime version here as well.
2 participants
… account number
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.