Include idempotency token by default#678
Include idempotency token by default#678gustavodiaz7722 wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gustavodiaz7722 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@gustavodiaz7722: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| // exposed in the CRD. Set this to true only if you need to expose | ||
| // idempotency token fields in the CRD. |
There was a problem hiding this comment.
p: It would be good to include an example of when this would be needed or clarify that this is intended to avoid breaking CRD changes in resources that already have it.
2 participants
Make
ignore_idempotency_tokenopt-out instead of opt-inIdempotency token fields (e.g.
ClientToken) are SDK implementation details auto-filled by middleware. Previously, each controller had to explicitly setignore_idempotency_token: trueto exclude them from CRDs.This PR flips the default: idempotency token fields are now excluded automatically. Controllers that need to keep them can set
include_idempotency_token: true.Changes
IgnoreIdempotencyTokentoIncludeIdempotencyTokeninResourceConfigmodel.goBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.