This repository was archived by the owner on Mar 28, 2025. It is now read-only.
fix for being unable to rename github repo#52
Open
zan-mateusz wants to merge 4 commits intoaws-ia:mainfrom
Open
fix for being unable to rename github repo#52zan-mateusz wants to merge 4 commits intoaws-ia:mainfrom
zan-mateusz wants to merge 4 commits intoaws-ia:mainfrom
Conversation
duncangrant
reviewed
Nov 3, 2023
Update delete handler to use repo id
rajdnp
reviewed
Dec 5, 2023
| "Name" | ||
| ], | ||
| "readOnlyProperties": [ | ||
| "/properties/Id", |
Contributor
There was a problem hiding this comment.
Might break existing stack updates. Please try testing following scenario :
1.Create a stack with out this changes(using current prod changes).
2.Update the stack with this changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Notes.
Nameproperty was in the list ofcreateOnlyProperties. Removed that so it can be used in update operationownerandnameproperties. This has caused issues when trying to update since the name was primaryIdentifier and therefore even though it was specified in update input, it used original value. If name was removed from primaryIdentifier list, it would be unable to call the api correctly for GET handler.IDinstead ofownerandname: see here for more reference: undocumented API - support piotrmurach/github#282