fix: Reporting schema issues and trailing whitespace#848
fix: Reporting schema issues and trailing whitespace#848LaikaN57 wants to merge 5 commits intoaws-ia:mainfrom
Conversation
|
I realize it's still in draft status, but many many thanks for this. |
|
|
||
| status = stack.status | ||
| status_class = "test-red" | ||
| status_icon = "❌" |
There was a problem hiding this comment.
Some attempt at accessibility for R/G colorblind.
| stylesheet = """th, td { | ||
| border: 1px solid black; | ||
| table { | ||
| border-collapse: collapse; | ||
| } | ||
| td.test-green { | ||
| background-color: #98FF98; | ||
| } | ||
| td.test-red { | ||
| background-color: #FCB3BC; | ||
| } | ||
| """ |
There was a problem hiding this comment.
Most basic stylesheet to convey the point of the test results with no fluff.
| def get_installed_version(): | ||
| return importlib.metadata.version(__package__ or __name__) |
There was a problem hiding this comment.
I took this from _cli.py. I had issues when using that version directly and when attempting to pull it out into _common_utils.py.
I might give this part one more attempt and then ask for help.
| self._output_file = output_file | ||
| self._version = version | ||
|
|
||
| # TODO: refactor for readability |
There was a problem hiding this comment.
@andrew-glenn I may have gone too far with the refactor here. If you don't mind just giving this a quick glance to see if you want me to break it up or not. (I do still need to do a little clean up on the tests.)
As it is right now, I have made the following improvements:
- fixed HTML validation issues
- fixed version footer
- added fallback stylesheet if GH is unreachable (or transient network errors)
- added R/G colorblind helper icons
- refactored the
yattagfunctions/contexts to be a bit more concise/readable (and prefered as per docs)
2 participants
Overview
Brief description of what this PR does, and why it is needed (use case)?
Fixes a bunch of HTML validation errors in the output reports.
Testing/Steps taken to ensure quality
How did you validate the changes in this PR?
TBD
Notes
Optional. Caveats, Alternatives, Other relevant information.
Testing Instructions
How to test this PR Start after checking out this branch (bulleted)