Skip to content

feat: gateway targets #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexa-perlov merged 5 commits into from
Dec 10, 2025
Merged

feat: gateway targets #12

alexa-perlov merged 5 commits into from
Dec 10, 2025

Conversation

@alexa-perlov
Copy link
Collaborator

@alexa-perlov alexa-perlov commented Nov 14, 2025

No description provided.

@alexa-perlov
Copy link
Collaborator Author

alexa-perlov commented Nov 14, 2025

/do-e2e-tests

@aws-ia-automator-prod
Copy link

aws-ia-automator-prod bot commented Nov 14, 2025

End to end test has been scheduled

@aws-ia-automator-prod
Copy link

aws-ia-automator-prod bot commented Nov 14, 2025

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot approved these changes Nov 14, 2025
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

dineshSajwan
dineshSajwan reviewed Dec 9, 2025
View reviewed changes
gateway.tf
"bedrock-agentcore:UpdateGatewayTarget",
"bedrock-agentcore:ListGatewayTargets"
]
Resource = [
Copy link
Collaborator

@dineshSajwan dineshSajwan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we supporting existing role with the gateway module. If yes, then we need to add assumerole policy.
https://docs.aws.amazon.com/bedrock-agentcore/latest/devguide/gateway-prerequisites-permissions.html#gateway-service-role-permissions
same with KMS key encryption. I don't see it in this module but if we are planning to then will have to add kms permission too.

Copy link
Collaborator Author

@alexa-perlov alexa-perlov Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already there (added before this PR for assume role:

terraform-aws-agentcore/gateway.tf

Line 70 in d2be2ce

# IAM Role for Agent Gateway
and for KMS:

terraform-aws-agentcore/gateway.tf

Line 122 in d2be2ce

policy = jsonencode({
)

@alexa-perlov alexa-perlov marked this pull request as ready for review December 9, 2025 17:58
MichaelWalker-git
MichaelWalker-git approved these changes Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gateway_target.tf
content {}
}

dynamic "api_key" {
Copy link
Collaborator

@MichaelWalker-git MichaelWalker-git Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

@alexa-perlov alexa-perlov merged commit 67aed67 into main Dec 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dineshSajwan dineshSajwan dineshSajwan left review comments

@MichaelWalker-git MichaelWalker-git MichaelWalker-git approved these changes

@aws-ia-automator-prod aws-ia-automator-prod[bot] aws-ia-automator-prod[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexa-perlov @MichaelWalker-git @dineshSajwan