Skip to content

Updating installer to support Python3.12 #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnnycs-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating installer to support Python3.12 #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions customization/nova-forge-hyperpod-cli-installation/INSTALL_USAGE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ echo $CONDA_DEFAULT_ENV # Should be empty or "base"

### 3. Python version

You need Python **3.8, 3.9, 3.10, or 3.11** installed. Python 3.12+ is not supported.
You need Python **3.8, 3.9, 3.10, 3.11, or 3.12** installed. Python 3.13+ is not supported.

```bash
python3 --version
Expand All @@ -53,7 +53,7 @@ python3 --version
If you need to install a compatible version on macOS:

```bash
brew install python@3.11
brew install python@3.12
```

### 4. Build tools
Expand Down Expand Up @@ -155,7 +155,7 @@ If you chose a custom installation directory, substitute `~/hyperpod-cli-env` wi
|---|---|
| `AWS credentials are not configured or invalid` | Run `aws configure` or refresh your session, then retry |
| `Active environment detected` | Run `deactivate` or `conda deactivate` and retry |
| `Python X.Y is not supported` | Install Python 3.8–3.11 and ensure `python3` points to it |
| `Python X.Y is not supported` | Install Python 3.8–3.12 and ensure `python3` points to it |
| `Failed to clone from S3` | Verify your AWS credentials have access to the S3 bucket and that `git-remote-s3` is working |
| Installation directory already exists | The installer will ask to remove it — say yes to start fresh, or choose a different path |
| `helm: command not found` when submitting a job | Install Helm: `curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 \| bash` |
22 changes: 11 additions & 11 deletions customization/nova-forge-hyperpod-cli-installation/install_hp_cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ check_python_version() {
update_progress "Checking Python version" "failed"
printf "\n"
print_error "python3 is not installed"
print_info "Please install Python 3.8, 3.9, 3.10, or 3.11"
print_info "Please install Python 3.8, 3.9, 3.10, 3.11, or 3.12"
exit 1
fi

Expand All @@ -309,12 +309,12 @@ check_python_version() {
print_info "Found Python version: ${python_version}"
fi

# Strict version check: only allow Python 3.8-3.11
# Strict version check: only allow Python 3.8-3.12
if [[ "$major" -ne 3 ]]; then
update_progress "Checking Python version" "failed"
printf "\n"
print_error "Python ${python_version} is not supported"
print_info "Required: Python 3.8, 3.9, 3.10, or 3.11"
print_info "Required: Python 3.8, 3.9, 3.10, 3.11, or 3.12"
printf "\n"
exit 1
fi
Expand All @@ -324,31 +324,31 @@ check_python_version() {
printf "\n"
print_error "Python ${python_version} is too old"
print_info "Minimum required: Python 3.8"
print_info "Supported versions: 3.8, 3.9, 3.10, 3.11"
print_info "Supported versions: 3.8, 3.9, 3.10, 3.11, 3.12"
printf "\n"
exit 1
fi

if [[ "$minor" -gt 11 ]]; then
if [[ "$minor" -gt 12 ]]; then
update_progress "Checking Python version" "failed"
printf "\n"
print_error "Python ${python_version} is not supported"
print_info "Maximum supported: Python 3.11"
print_info "Supported versions: 3.8, 3.9, 3.10, 3.11"
print_info "Maximum supported: Python 3.12"
print_info "Supported versions: 3.8, 3.9, 3.10, 3.11, 3.12"
printf "\n"
print_info "To install a compatible Python version:"
if [[ "$OSTYPE" == "darwin"* ]]; then
print_info " brew install python@3.11"
print_info " Then use: python3.11 instead of python3"
print_info " brew install python@3.12"
print_info " Then use: python3.12 instead of python3"
else
print_info " Use pyenv or your system package manager"
print_info " Example: sudo apt-get install python3.11"
print_info " Example: sudo apt-get install python3.12"
fi
printf "\n"
exit 1
fi

# Version is in the supported range (3.8-3.11)
# Version is in the supported range (3.8-3.12)
if [[ $DEBUG_MODE -eq 1 ]]; then
print_success "Python version ${python_version} is compatible"
fi
Expand Down