Skip to content

fix(pg): prevent process crash during Aurora failover #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azihsoyn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pg): prevent process crash during Aurora failover #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pg/lib/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,11 @@ class AwsPGPooledConnection extends BaseAwsPgClient {
throw new UndefinedClientError();
}
this.pluginService.removeErrorListener(this.targetClient);
return await this.targetClient.client.release();
// After failover, the new target client may not have a release() method
// (e.g., a direct connection instead of a pooled connection).
if (typeof this.targetClient.client?.release === "function") {
return await this.targetClient.client.release();
}
},
null
);
Expand Down
6 changes: 6 additions & 0 deletions pg/lib/icp/pg_internal_pool_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ export class AwsPgInternalPoolClient implements AwsInternalPoolClient {

constructor(props: pkgPg.PoolConfig) {
this.targetPool = new pkgPg.Pool(props);
// Handle idle client errors to prevent process crash during Aurora failover.
// When a failover occurs, idle connections in the pool are terminated by the server,
// which emits 'error' events. Without this handler, Node.js throws an uncaught exception.
this.targetPool.on("error", () => {
// Intentionally swallowed. The failover plugin will handle reconnection.
});
}

async end(): Promise<any> {
Expand Down