Address Access Log Subscription Test Failures #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mikestvz
reviewed
Jun 13, 2025
| } | ||
| alp := &anv1alpha1.AccessLogPolicy{} | ||
| err := testFramework.Client.Get(ctx, alpNamespacedName, alp) | ||
| g.Expect(err).To(BeNil()) |
Contributor
There was a problem hiding this comment.
Any reason to remove these asserts?
Author
There was a problem hiding this comment.
I opted to remove them in favour of the asserts following. The later asserts could not pass if these access log polices were not created anyways.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
ghost
enabled auto-merge
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
Which issue does this PR fix:
#733
What does this PR do / Why do we need it:
This corrects failing access log subscription tests that were previously disabled. The impacted assertions are safe to remove as the following assertions that check for the existence/non-existence of the subscriptions are enough to confirm a success. I also manually verified through the AWS console.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
N/A
Testing done on this change:
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No.
Does this PR introduce any user-facing change?:
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.