generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 71
feat: implement Gateway API allowedRoutes namespace and kind validation #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Nov 28, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
…on (#845) * feat: implement Gateway API allowedRoutes namespace and kind validation * fix tests * fix unit tests --------- Co-authored-by: VikramBedi <vbedi@amazon.com> Co-authored-by: Ryan Lymburner <137918933+rlymbur@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…on (#845) * feat: implement Gateway API allowedRoutes namespace and kind validation * fix tests * fix unit tests * add assertions to wait for gateway to be updated before each test * use diff namespace for label selector test --------- Co-authored-by: VikramBedi <vbedi@amazon.com> Co-authored-by: Ryan Lymburner <137918933+rlymbur@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…on (#845) * feat: implement Gateway API allowedRoutes namespace and kind validation * fix tests * fix unit tests * add assertions to wait for gateway to be updated before each test * use diff namespace for label selector test * Add namespace RBAC permissions for Gateway listener namespace selectors --------- Co-authored-by: VikramBedi <vbedi@amazon.com> Co-authored-by: Ryan Lymburner <137918933+rlymbur@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
#786
What does this PR do / Why do we need it:
Implements Gateway API
allowedRoutesvalidation to control which Routes can attach to Gateway listeners.Testing done on this change:
Tested manually and added e2e tests
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
This change might break existing Routes. Routes violating allowedRoutes will be rejected and show
Accepted: falsestatus. Breaking scenarios include:Old version of controller ignores default validation
Does this PR introduce any user-facing change?:
Do all end-to-end tests successfully pass when running
make e2e-test?:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.