Skip to content

fix: Add VPC ID validation for RAM service network discovery #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SinghVikram97 merged 2 commits into from
Dec 6, 2025
Merged

fix: Add VPC ID validation for RAM service network discovery #858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dd4abc
fix: Add VPC ID validation for RAM service network discovery
Dec 5, 2025
0abdbfa
Merge branch 'main' into fix/vpc-id-validation-ram-discovery
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/aws/services/vpclattice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,11 @@ func (d *defaultLattice) buildServiceNetworkInfo(ctx context.Context, snMatch *v
// by examining VPC associations. This is used to discover RAM-shared
// service networks that don't appear in ListServiceNetworks.
func (d *defaultLattice) findServiceNetworkViaVPCAssociation(ctx context.Context, nameOrId string) (*ServiceNetworkInfo, error) {
// Validate that VPC ID is configured
if config.VpcID == "" {
return nil, fmt.Errorf("cannot discover RAM-shared service networks: CLUSTER_VPC_ID environment variable is not set")
}

// List all VPC-to-Service Network associations for the controller's VPC
associations, err := d.ListServiceNetworkVpcAssociationsAsList(ctx,
&vpclattice.ListServiceNetworkVpcAssociationsInput{
Expand Down