Skip to content

feat(aws-cdk): surface custom resource Lambda logs on deployment failure #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iankhou wants to merge 7 commits into
base: main
Choose a base branch
from
+985 −18
Draft

feat(aws-cdk): surface custom resource Lambda logs on deployment failure #1645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
10e0fd8
feat(toolkit-lib): surface custom resource Lambda logs on deployment …
iankhou Jun 18, 2026
29d0e7f
fix(toolkit-lib): harden custom resource log resolution from code review
iankhou Jun 19, 2026
4bdec27
refactor(toolkit-lib): share log-line trimming between ECS and custom…
iankhou Jun 19, 2026
7687d8a
feat(toolkit-lib): label custom resource logs with their log group
iankhou Jun 19, 2026
fe92fd8
fix(toolkit-lib): read custom resource log group from template, not l…
iankhou Jun 19, 2026
d638aad
fix(toolkit-lib): resolve CloudFormation-generated custom resource lo…
iankhou Jun 19, 2026
189399d
feat(toolkit-lib): normalize custom resource Lambda logs for readability
iankhou Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/@aws-cdk/toolkit-lib/lib/api/aws-auth/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,9 @@ import {
type ListAliasesCommandOutput,
} from '@aws-sdk/client-kms';
import {
GetFunctionConfigurationCommand,
type GetFunctionConfigurationCommandInput,
type GetFunctionConfigurationCommandOutput,
InvokeCommand,
type InvokeCommandInput,
type InvokeCommandOutput,
Expand Down Expand Up @@ -598,6 +601,7 @@ export interface IKMSClient {
}

export interface ILambdaClient {
getFunctionConfiguration(input: GetFunctionConfigurationCommandInput): Promise<GetFunctionConfigurationCommandOutput>;
invokeCommand(input: InvokeCommandInput): Promise<InvokeCommandOutput>;
publishVersion(input: PublishVersionCommandInput): Promise<PublishVersionCommandOutput>;
updateAlias(input: UpdateAliasCommandInput): Promise<UpdateAliasCommandOutput>;
Expand Down Expand Up @@ -1048,6 +1052,8 @@ export class SDK {
public lambda(): ILambdaClient {
const client = new LambdaClient(this.config);
return {
getFunctionConfiguration: (input: GetFunctionConfigurationCommandInput): Promise<GetFunctionConfigurationCommandOutput> =>
client.send(new GetFunctionConfigurationCommand(input)),
invokeCommand: (input: InvokeCommandInput): Promise<InvokeCommandOutput> => client.send(new InvokeCommand(input)),
publishVersion: (input: PublishVersionCommandInput): Promise<PublishVersionCommandOutput> =>
client.send(new PublishVersionCommand(input)),
Expand Down
Loading
Loading