Skip to content

fix: mitigate script injection in release workflow #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaythomas merged 1 commit into from
Jun 30, 2026
Merged

fix: mitigate script injection in release workflow #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/workflows/release_maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ permissions:
jobs:
release:
runs-on: ubuntu-latest
env:
RELEASE_VERSION: ${{ github.event.inputs.release_version }}
NEXT_VERSION: ${{ github.event.inputs.next_version }}

steps:
- name: Checkout
Expand Down Expand Up @@ -267,14 +270,16 @@ jobs:
cache: maven

- name: Set release version
run: mvn -q versions:set -DnewVersion=${{ github.event.inputs.release_version }} -DgenerateBackupPoms=false
run: mvn -q versions:set -DnewVersion="$RELEASE_VERSION" -DgenerateBackupPoms=false

- name: Commit release version
env:
GIT_ACTOR: ${{ github.actor }}
run: |
git config user.email "${{ github.actor }}+github-actions[bot]@users.noreply.github.com"
git config user.name "${{ github.actor }}+github-actions[bot]"
git config user.email "${GIT_ACTOR}+github-actions[bot]@users.noreply.github.com"
git config user.name "${GIT_ACTOR}+github-actions[bot]"

@zhongkechen zhongkechen Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No special character is allowed in github username.

git add .
git commit -m "chore: release version ${{ github.event.inputs.release_version }}"
git commit -m "chore: release version ${RELEASE_VERSION}"

- name: Push changes
uses: ad-m/github-push-action@881a6320fdb16eb5318c5054f31c218aec2b324c # master
Expand All @@ -299,19 +304,18 @@ jobs:
- name: Sign and publish
run: bash .github/scripts/maven_publish.sh
env:
RELEASE_VERSION: ${{ github.event.inputs.release_version }}
MVN_GPG_KEYS_GPGPRIVATEKEY: ${{ secrets.MVN_GPG_KEYS_GPGPRIVATEKEY }}
MVN_GPG_KEYS_GPGPASSPHRASE: ${{ secrets.MVN_GPG_KEYS_GPGPASSPHRASE }}
MVN_ACCOUNT_KEYS_USERNAME: ${{ secrets.MVN_ACCOUNT_KEYS_USERNAME }}
MVN_ACCOUNT_KEYS_PASSWORD: ${{ secrets.MVN_ACCOUNT_KEYS_PASSWORD }}

- name: Set next development version
run: mvn -q versions:set -DnewVersion=${{ github.event.inputs.next_version }} -DgenerateBackupPoms=false
run: mvn -q versions:set -DnewVersion="$NEXT_VERSION" -DgenerateBackupPoms=false

- name: Commit release version
- name: Commit next development version
run: |
git add .
git commit -m "chore: bump version to ${{ github.event.inputs.next_version }}"
git commit -m "chore: bump version to ${NEXT_VERSION}"

- name: Push changes
uses: ad-m/github-push-action@881a6320fdb16eb5318c5054f31c218aec2b324c # master
Expand Down