[integ-tests-framework] Dump job output when job state assertion fails

[hanwen-cluster]

Description of changes

The _dump_job_output has been there in the codebase without anyone using it. This commit uses it. This commit also change an ERROR meesage in the function to INFO to avoid polluting logs with too many ERRORs

Tests

When test_starccm fails, the job stdout and stderr is in the console output

Checklist

• Make sure you are pointing to the right branch.
• If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
• Check all commits' messages are clear, describing what and why vs how.
• Make sure to have added unit tests or integration tests to cover the new/modified code.
• Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[hehe7318]

I saw you wrote this in description.

The _dump_job_output has been there in the codebase without anyone using it.

Why? Does the original call of this function not work?

[hanwen-cluster]

Nobody called this function before this commit

[hehe7318]

Correct me if I am wrong. There was one and you modified it.
Original:

        try:
            assert_that(result.stdout).contains(f"JobState={expected_state}")
        except AssertionError:
            logging.error("JobState of jobid %s not in %s:\n%s", job_id, expected_state, result.stdout)
            self._dump_job_output(result.stdout)

Now:

        if f"JobState={expected_state}" not in result.stdout:
            logging.error("JobState of jobid %s not in %s:\n%s", job_id, expected_state, result.stdout)
            self._dump_job_output(job_id, result.stdout)
        assert_that(result.stdout).contains(f"JobState={expected_state}")

[hanwen-cluster]

You are right! I am closing the PR. Sorry about the confusion!