Skip to content

misc: track upstream AwsHttpBindingProtocolGenerator deletion #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0marperez wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

misc: track upstream AwsHttpBindingProtocolGenerator deletion #1756

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19479fe
track upstream HttpBindingProtocolGenerator refactor
0marperez Dec 17, 2025
54b3130
rerun CI
0marperez Dec 17, 2025
7ff6ba8
rerun CI
0marperez Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...odegen/src/main/kotlin/aws/sdk/kotlin/codegen/customization/s3/S3OperationErrorHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
package aws.sdk.kotlin.codegen.customization.s3

import software.amazon.smithy.kotlin.codegen.KotlinSettings
import software.amazon.smithy.kotlin.codegen.aws.protocols.core.AwsHttpBindingProtocolGenerator
import software.amazon.smithy.kotlin.codegen.core.*
import software.amazon.smithy.kotlin.codegen.integration.KotlinIntegration
import software.amazon.smithy.kotlin.codegen.integration.SectionWriter
import software.amazon.smithy.kotlin.codegen.integration.SectionWriterBinding
import software.amazon.smithy.kotlin.codegen.model.buildSymbol
import software.amazon.smithy.kotlin.codegen.model.expectShape
import software.amazon.smithy.kotlin.codegen.rendering.ExceptionBaseClassGenerator
import software.amazon.smithy.kotlin.codegen.rendering.protocol.HttpBindingProtocolGenerator
import software.amazon.smithy.kotlin.codegen.rendering.protocol.ProtocolGenerator
import software.amazon.smithy.model.Model
import software.amazon.smithy.model.shapes.OperationShape
Expand All @@ -30,11 +30,11 @@ class S3OperationErrorHandler : KotlinIntegration {
}

override val sectionWriters: List<SectionWriterBinding>
get() = listOf(SectionWriterBinding(AwsHttpBindingProtocolGenerator.Sections.RenderThrowOperationError, overrideThrowOperationErrors))
get() = listOf(SectionWriterBinding(HttpBindingProtocolGenerator.Sections.RenderThrowOperationError, overrideThrowOperationErrors))

private val overrideThrowOperationErrors = SectionWriter { writer, _ ->
val ctx = writer.getContextValue(AwsHttpBindingProtocolGenerator.Sections.RenderThrowOperationError.Context)
val op = writer.getContextValue(AwsHttpBindingProtocolGenerator.Sections.RenderThrowOperationError.Operation)
val ctx = writer.getContextValue(HttpBindingProtocolGenerator.Sections.RenderThrowOperationError.Context)
val op = writer.getContextValue(HttpBindingProtocolGenerator.Sections.RenderThrowOperationError.Operation)
renderThrowOperationError(ctx, op, writer)
}

Expand Down
Loading