fix user pools in tests not being cleaned up #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettBeatty
added
the
Release Not Needed
normj
approved these changes
Oct 2, 2025
sankettangade
approved these changes
Oct 2, 2025
GarrettBeatty
added a commit
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We had some tests where the user pools were not being cleaned up because of failures in the constructor in the tests. When something in the constructor fails it doesnt call dispose. This change makes it so that if anything fails in the consructor we call dispose to cleanup the resources.
I tested in my own account by running without the changes and verified nothing was cleanup when something fails in the constructor. i then ran the tests with my changes and everything was cleaned up
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.