Allows Cloudshell to acquire perm from AWS_CONTAINER_CREDENTIALS_FULL… #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Contributor
|
This would also solve issue #2249 |
stobrien89
requested changes
Mar 11, 2022
Member
stobrien89
left a comment
stobrien89
left a comment
There was a problem hiding this comment.
Hi @kuettai,
Thanks for the pull request! Apologies for the delay. I think this is something we'd be open to accepting. Would it be possible for you to rebase and add some unit tests in EcsCredentialProvider.php and CredentialProviderTest.php?
Contributor
Author
Acknowledged. Will do later. |
Member
|
Hi @kuettai, Closing this one in favor of your new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_URI
Issue #, if available:
#2323
Description of changes:
Added supports for AWS_CONTAINER_CREDENTIALS_FULL_URI in EcsCredentialProvider.php, this will allows aws-php-sdk to works with CloudShell correctly. Permission in Cloudshell to follow IAM User.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.