fix(daily-scan): move DependencyCheck install to /tmp to avoid self-scan#114
Closed
fix(daily-scan): move DependencyCheck install to /tmp to avoid self-scan#114
Conversation
…can false positives
Contributor
Author
|
Incorrect fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DependencyCheck is unzipped into the repo checkout directory, then scans
.which includes its owndependency-check/lib/*.jarfiles. This causes false positive CVE findings (commons-beanutils, gson, h2, httpclient5, logback-core, etc.) on every run.This PR moves the unzip to
/tmpso the tool binaries are outside the scan path.Ref: V1902405376