Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 79.78% 79.71% -0.08%
==========================================
Files 28 28
Lines 12082 12110 +28
==========================================
+ Hits 9640 9653 +13
- Misses 2442 2457 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
azkrishpy
reviewed
Mar 4, 2026
| /* RFC-7230 section 3.3 Message Body */ | ||
| decoder->body_headers_ignored |= code_val == AWS_HTTP_STATUS_CODE_304_NOT_MODIFIED; | ||
| if (decoder->body_headers_ignored_on_2xx) { | ||
| decoder->body_headers_ignored |= code_val / 200 == 1; |
Contributor
There was a problem hiding this comment.
2xx (Successful) responses to a CONNECT request method (Section 4.3.6 of[RFC7231])
switch to tunnel mode instead of having a message body. All 1xx (Informational),
204 (No Content), and 304 (Not Modified) responses do not include a message body.
All other responses do include a message body, although the body might be of zero length.
we seem to ignore body for any value between 200 and 400? Is that correct?
Contributor
Author
There was a problem hiding this comment.
yeah, I was wrong about the math, this is supposed to be status code from 200-299.
Good catch!
…nups
- Fix code_val/200==1 to code_val/100==2 (matched 200-399 instead of 200-299)
- Add unit tests for indeterminate-length response body:
- h1_client_response_indeterminate_length_body (multi-chunk body)
- h1_client_response_indeterminate_length_empty_body (empty body edge case)
- h1_client_response_204_no_indeterminate_length (negative case)
- Fix typo: 'response lien' -> 'response line'
- Reset body_headers_ignored_on_2xx in s_reset_state() for consistency
- Fix inconsistent Server header in mock server ('echo-server' -> 'crt-local-server')
# Conflicts: # tests/CMakeLists.txt # tests/test_h1_client.c
…inate-length compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.