Skip to content

Fail http proxy configuration when using SecItem#551

Merged
xiazhvera merged 11 commits intomainfrom
http_proxy_warning
Mar 2, 2026
Merged

Fail http proxy configuration when using SecItem#551
xiazhvera merged 11 commits intomainfrom
http_proxy_warning

Conversation

@xiazhvera
Copy link
Copy Markdown
Contributor

@xiazhvera xiazhvera commented Feb 23, 2026

Issue #, if available:

Description of changes:
Http proxy is not supported when using Apple Network Framework and will now fail during config validation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera xiazhvera changed the title Add error handling for http proxy on iOS&tvOS Fail http proxy configuration using SecItem Feb 24, 2026
@xiazhvera xiazhvera changed the title Fail http proxy configuration using SecItem Fail http proxy configuration when using SecItem Feb 24, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.75%. Comparing base (a9745ea) to head (e9cdaa4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   79.72%   79.75%   +0.02%     
==========================================
  Files          28       28              
  Lines       11894    11893       -1     
==========================================
+ Hits         9483     9485       +2     
+ Misses       2411     2408       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread source/connection.c Outdated
@xiazhvera xiazhvera merged commit 0d8e1a9 into main Mar 2, 2026
45 checks passed
@xiazhvera xiazhvera deleted the http_proxy_warning branch March 2, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants