Open
Conversation
get_name in forward hook
get_name in forward hook
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 85.49% 82.63% -2.86%
==========================================
Files 86 86
Lines 6514 6520 +6
==========================================
- Hits 5569 5388 -181
- Misses 945 1132 +187
Continue to review full report at Codecov.
|
b1a4be4 to
9e6a581
Compare
Vikas-kum
reviewed
Oct 30, 2020
Contributor
Vikas-kum
left a comment
There was a problem hiding this comment.
Can you check if module.modules will work, as it will give you modules recursively. https://discuss.pytorch.org/t/module-children-vs-module-modules/4551
| for name, submodule in module.named_modules(): | ||
| assert submodule not in self.module_set, f"Don't register module={module} twice" | ||
| submodule._module_name = name | ||
| Hook._add_module_name(submodule, name) |
| self.register_module(module) | ||
|
|
||
| @staticmethod | ||
| def _add_module_name(module, module_name): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of bug:
DataParallelCriterionorDataParallelThe problem with the above line is that the
_module_nameattribute is attached to theparallel_custom_loss_moduleand not the nestedcustom_loss_module.We should instead simply use:
module._get_name()in theforward_hookStyle and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.