Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
===========================================
- Coverage 76.91% 62.72% -14.19%
===========================================
Files 113 113
Lines 10195 10237 +42
===========================================
- Hits 7841 6421 -1420
- Misses 2354 3816 +1462
Continue to review full report at Codecov.
|
update with origin
851bc3d to
00eb6ac
Compare
00eb6ac to
21c4b22
Compare
ndodda-amazon
suggested changes
Jan 20, 2021
Contributor
ndodda-amazon
left a comment
There was a problem hiding this comment.
Changes look good, comments are mostly around reducing code redundancy in your implementation and the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This commit is to enable profiler in the tf2 native training (design doc: https://quip-amazon.com/v0MwAkTizZl9/Profiler-for-TensorFlow2-native-training). The corresponding integration tests for tf 2.2 and 2.3 passed successfully.
TF2.2 integration test: https://console.aws.amazon.com/codesuite/codebuild/072677473360/projects/smprofiler_tf2_integration_tests/build/smprofiler_tf2_integration_tests%3A2bff3f63-b797-4c5e-9992-0fdf17f13bec?region=us-east-1
TF2.3 integration test:
https://console.aws.amazon.com/codesuite/codebuild/072677473360/projects/smprofiler_tf_2_3_integration_tests/build/smprofiler_tf_2_3_integration_tests%3A801a9a02-30b5-4af6-9835-9b01a6ed6ce4/?region=us-east-1
The changes include:
Style and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.