[Do-Not-Merge] Ignore sagemaker-uploading#470
Open
NihalHarish wants to merge 4 commits intomasterfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
===========================================
- Coverage 65.53% 50.00% -15.53%
===========================================
Files 173 163 -10
Lines 13280 12934 -346
===========================================
- Hits 8703 6468 -2235
- Misses 4577 6466 +1889
Continue to review full report at Codecov.
|
| @@ -1 +1 @@ | |||
| __version__ = "1.0.8" | |||
| __version__ = "1.0.8b" | |||
| file != METADATA_FILENAME | ||
| and file != METADATA_FILENAME_S3_UPLOADED | ||
| and "sagemaker-uploaded" not in file | ||
| and "sagemaker-uploading" not in file |
Contributor
There was a problem hiding this comment.
nit: This won't scale well. Can we keep track of a list of files not to append and then do something like:
if all([metadata_file not in file for metadata_file in metadata_files])
NihalHarish
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Style and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.