Conversation
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
- Coverage 66.25% 65.40% -0.86%
==========================================
Files 173 163 -10
Lines 13275 12942 -333
==========================================
- Hits 8796 8465 -331
+ Misses 4479 4477 -2
Continue to review full report at Codecov.
|
| @@ -1 +1 @@ | |||
| __version__ = "1.0.8" | |||
| __version__ = "1.0.8c0" | |||
| tag = tname | ||
| tensor_proto = make_tensor_proto(nparray_data=value, tag=tag) | ||
| s = Summary(value=[Summary.Value(tag=tag, metadata=smd, tensor=tensor_proto)]) | ||
| self.logger.debug(f"smdebug: writing tensor: {tname}") |
There was a problem hiding this comment.
Shouldn't the logger itself handle prepending smdebug as an identifier to each logging message?
|
|
||
| def _prepare_collections_for_tf2(self): | ||
| self._prepare_collections() | ||
| self.logger.debug("SMDEBUG: Preparing Collections") |
There was a problem hiding this comment.
Case of "smdebug" is inconsistent. There should be some higher level wrapper that manages prepending "smdebug" so that it isn't expected for the writer of the log to remember to prepend "smdebug".
3 participants
Description of changes:
Style and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.