[DO Not Merge] Avoid using 'default' keyword while invoking 'get' method#473
Open
[DO Not Merge] Avoid using 'default' keyword while invoking 'get' method#473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 65.53% 65.09% -0.45%
==========================================
Files 173 163 -10
Lines 13280 12934 -346
==========================================
- Hits 8703 8419 -284
+ Misses 4577 4515 -62
Continue to review full report at Codecov.
|
Contributor
|
Let's not merge this. |
leleamol
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
As mentioned in the issue #418 customers may see the error because of having 'default' keyword in the 'get()' call.
This change avoid using this keyword argument in 'get()' call to avoid potential issues.
As mentioned in the issue, the tokenizer in transformers package is modifying the data type of os.environ from os.Environ to 'dict'. The change in this PR is for protecting smdebug from such changes while keeping the behavior same.
Style and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.