Fix default value of end_time in update_end_time#665
Open
ChristopherBrix wants to merge 1 commit intoawslabs:masterfrom
Open
Fix default value of end_time in update_end_time#665ChristopherBrix wants to merge 1 commit intoawslabs:masterfrom
ChristopherBrix wants to merge 1 commit intoawslabs:masterfrom
Conversation
Using `time.time()` in the definition of the method would freeze the default to the time at the definition. Defining it in the body allows to query the current time when the method is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Using
time.time()in the definition of the method would freeze the default to the time at the definition. Defining it in the body allows to query the current time when the method is called.Style and formatting:
I have not run
pre-commit install && pre-commit run --all-files, as it seems to be broken (see issue #664).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.