XIVY-19259 fix: permission check on intermediate event detail page#925
Open
ivy-lgi wants to merge 1 commit into
Open
XIVY-19259 fix: permission check on intermediate event detail page#925ivy-lgi wants to merge 1 commit into
ivy-lgi wants to merge 1 commit into
Conversation
Member
Author
|
I tried to introduce some tests for all these permission checks but changing the engine mode during tests results in a lot of issues because it affects other tests. |
ivy-lli
approved these changes
Jul 8, 2026
Also tighten permission check on cleanup page to align with "Developer" menu in sidebar and rename some methods to better reflect what they actually check.
ivy-lgi
force-pushed
the
improve-page-permissions
branch
from
July 13, 2026 06:10
d739dd6 to
f479c73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also tighten permission check on cleanup page to align with "Developer" menu in sidebar and rename some methods to better reflect what they actually check.