fix(providers): the company is called Drime, not Drime Cloud (#347) - #520
Merged
Conversation
Ehud read the tracker note where I recorded "Drime Cloud" as a name AeroFTP was getting wrong in reverse, and said the reverse was the mistake: it is just Drime. He is right, and their own site says so — the title tag reads "Drime | Secure File Collaboration & Cloud Storage Solutions", the page says "Drime is easy to use, secure, and built for everyone", and "Drime Cloud" appears only inside the app.drime.cloud URL. The catalogue had it inside out: `company: 'Drime Cloud', parentCompany: 'Drime'`, as though the cloud drive were a product under a parent company, the way pCloud Drive sits under pCloud. There is no parent here, so the entry is now simply Drime, and README, docs/PROVIDERS.md and cli_catalog.json are regenerated from it rather than edited. Renamed where a person reads it: eleven strings across the GUI, 48 across all 47 locale files, seven user-facing strings in the Rust provider (its display name, its connection and rate-limit errors, its quota line) and the provider tables in the docs. Deliberately unchanged: the `drime` protocol id, the `DrimeCloud` enum variant, `drime_cloud.rs` and the comments inside it — none of which the user ever sees — and SECURITY-EVIDENCE-v2.6.4.md, which is a dated record of what was true then. Reported by @EhudKirsh in discussion #347.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughThe PR renames the Drime provider from “Drime Cloud” to “Drime” across backend strings, frontend displays, catalogs, documentation, and all localized protocol descriptions. ChangesDrime provider rename
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 111: Add an alt attribute with descriptive text such as “Drime” to the
image element in the Drime provider-grid entry, preserving the existing link,
source, dimensions, and label.
In `@src/i18n/locales/en.json`:
- Around line 2728-2729: Update the drimeDesc and drimeTooltip localization
strings so both use the same verified Drime storage quota, preserving their
existing descriptive and tooltip wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ff53d22b-b1ae-421a-b6bd-6f962b6fe67c
📒 Files selected for processing (62)
README.mddocs/PROTOCOL-FEATURES.mddocs/PROVIDER-INTEGRATION-GUIDE.mddocs/PROVIDERS.mdsrc-tauri/src/cli_catalog.jsonsrc-tauri/src/providers/drime_cloud.rssrc-tauri/src/providers/types.rssrc/App.tsxsrc/components/ConnectionScreen.tsxsrc/components/DevTools/aiChatSystemPrompt.tssrc/components/IntroHub/discoverData.tssrc/components/ProtocolSelector.tsxsrc/components/ProvidersDialog.tsxsrc/components/SavedServers.tsxsrc/components/providerCatalog.tssrc/i18n/locales/bg.jsonsrc/i18n/locales/bn.jsonsrc/i18n/locales/ca.jsonsrc/i18n/locales/cs.jsonsrc/i18n/locales/cy.jsonsrc/i18n/locales/da.jsonsrc/i18n/locales/de.jsonsrc/i18n/locales/el.jsonsrc/i18n/locales/en.jsonsrc/i18n/locales/es.jsonsrc/i18n/locales/et.jsonsrc/i18n/locales/eu.jsonsrc/i18n/locales/fi.jsonsrc/i18n/locales/fr.jsonsrc/i18n/locales/gl.jsonsrc/i18n/locales/hi.jsonsrc/i18n/locales/hr.jsonsrc/i18n/locales/hu.jsonsrc/i18n/locales/hy.jsonsrc/i18n/locales/id.jsonsrc/i18n/locales/is.jsonsrc/i18n/locales/it.jsonsrc/i18n/locales/ja.jsonsrc/i18n/locales/ka.jsonsrc/i18n/locales/km.jsonsrc/i18n/locales/ko.jsonsrc/i18n/locales/lt.jsonsrc/i18n/locales/lv.jsonsrc/i18n/locales/mk.jsonsrc/i18n/locales/ms.jsonsrc/i18n/locales/nl.jsonsrc/i18n/locales/no.jsonsrc/i18n/locales/pl.jsonsrc/i18n/locales/pt.jsonsrc/i18n/locales/ro.jsonsrc/i18n/locales/ru.jsonsrc/i18n/locales/sk.jsonsrc/i18n/locales/sl.jsonsrc/i18n/locales/sr.jsonsrc/i18n/locales/sv.jsonsrc/i18n/locales/sw.jsonsrc/i18n/locales/th.jsonsrc/i18n/locales/tl.jsonsrc/i18n/locales/tr.jsonsrc/i18n/locales/uk.jsonsrc/i18n/locales/vi.jsonsrc/i18n/locales/zh.json
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #519 so both changes fit under CodeRabbit's 100-file review limit: this one is a rename, 47 of its files are locale JSONs, and it reads better on its own anyway.
@EhudKirsh read the tracker note where I had recorded "Drime Cloud" as a name AeroFTP was getting wrong in reverse, and told me the reverse was the mistake:
He is right. Their title tag reads "Drime | Secure File Collaboration & Cloud Storage Solutions", the page says "Drime is easy to use, secure, and built for everyone", and "Drime Cloud" appears only inside the
app.drime.cloudURL.The catalogue had it inside out —
company: 'Drime Cloud', parentCompany: 'Drime'— as though the cloud drive were a product under a parent company, the way pCloud Drive sits under pCloud. There is no parent here, so the entry is now simplycompany: 'Drime', and README,docs/PROVIDERS.mdandcli_catalog.jsonare regenerated from it (gen:providers-table,gen:cli-catalog) rather than hand-edited, so the tables that the drift guard test compares cannot fall out of step.Renamed where a person reads it: eleven strings across the GUI, 48 across all 47 locale files, and seven user-facing strings in the Rust provider — its display name, its connection and rate-limit errors, and its quota line.
Deliberately unchanged, since nobody sees them: the
drimeprotocol id, theDrimeCloudenum variant,drime_cloud.rsand the comments inside it. Also unchanged isSECURITY-EVIDENCE-v2.6.4.md, which is a dated record of what was true at the time.Verification
tscclean,npm run buildok,vitest545/545 (the README/PROVIDERS drift guards pass against the regenerated tables),cargo check --all-featuresclean,cargo fmt --checkclean,i18n:validate46/46 with 0 missing keys and 0 placeholders.Reported by @EhudKirsh in discussion #347.
Not marked as closing anything: the thread stays open for the reporter to confirm.
Summary by CodeRabbit
Documentation
User Interface
Localization
Error Messages