Skip to content

Remove wrong implementation of MaxSubArraySum #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aruku wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove wrong implementation of MaxSubArraySum #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions exercises/MaxSubArraySum/Complete/MaxSubArraySumComplete.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,28 +32,4 @@ public static function max1(array $input, int $n): int

return $max;
}

/** @param int[] $input */
public static function max2(array $input, int $n): int
{
$length = count($input);
if ($length < $n) {
return 0;
}
$maxSum = 0;
$tempSum = 0;

for ($i = 0; $i < $n; ++$i) {
$maxSum += $input[$i];
}

$tempSum = $maxSum;

for ($i = $n; $i < $length; ++$i) {
$tempSum = ($tempSum - $input[$i - $n] + $input[$i]);
$maxSum = max($maxSum, $tempSum);
}

return $maxSum;
}
}
2 changes: 1 addition & 1 deletion exercises/MaxSubArraySum/MaxSubArraySum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*
* @method static int max(int[] $input, int $n)
* @example MaxSubArraySum::max([1, 2, 3], 2)) === 5
* @example MaxSubArraySum::max([2, 6, 9, 2, 1, 8, 5, 6, 3], 3)) === 19
* @example MaxSubArraySum::max([2, 6, 9, 2, 1, 8, 5, 6, 3], 3)) === 23
*/
final class MaxSubArraySum
{
Expand Down
14 changes: 0 additions & 14 deletions tests/MaxSubArraySum/Complete/MaxSubArrayCompleteTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ public function testHasMethods(): void
method_exists(MaxSubArraySumComplete::class, 'max1'),
'Class does not have static method max1'
);
self::assertTrue(
method_exists(MaxSubArraySumComplete::class, 'max2'),
'Class does not have static method max2'
);
}

public function testMax1(): void
Expand All @@ -31,14 +27,4 @@ public function testMax1(): void
);
self::assertSame(0, MaxSubArraySumComplete::max1([1, 2, 3], 5));
}

public function testMax2(): void
{
self::assertSame(5, MaxSubArraySumComplete::max2([1, 2, 3], 2));
self::assertSame(
19,
MaxSubArraySumComplete::max2([2, 6, 9, 2, 1, 8, 5, 6, 3], 3)
);
self::assertSame(0, MaxSubArraySumComplete::max1([1, 2, 3], 5));
}
}