feat: integrate gateway api endpoint for chart deployment#329
Conversation
|
@tboerger Thanks for this, could you perhaps add a CI test for the gateway api resources? |
|
Sure, let me check that. |
|
I have added charts/backstage/ci/httproute-values.yaml now. |
The Gateway API had been established as the new standard as an alternative for Ingress resources. With this change it's possible to deploy the HTTPRoute resource directly as part of the chart. Signed-off-by: Thomas Boerger <thomas@webhippie.de>
2a2d36b to
6b4e237
Compare
|
I have checked everything with pre-commit now, it should be fine :) |
|
Hi @tboerger thank you for opening your PR! 🙌 I 💯 agree with you that Backstage chart should have support for Gateway, it's a great addition. However it seems our CI is not currently ready. This is not an issue with your PR by itself, yet it is still required to adjust the test setup before we can merge your PR. The issue is that we use a Kind cluster to test the chart and this cluster has no Gateway provider. I suggest we extend it with (see: https://kubernetes.io/blog/2026/01/28/experimenting-gateway-api-with-kind/ ) Here is where we need to extend the workflow: charts/.github/workflows/test.yml Lines 45 to 55 in 38a8122 |
|
@tumido I think it does not even need the kind cloud provider, it should be already enough to install the Gateway API CRDs to get the tests working as expected. |
Signed-off-by: Thomas Boerger <thomas@webhippie.de>
|
Looks like this solved the testing :) |
tumido
left a comment
There was a problem hiding this comment.
I think I found just one little deviation from the upstream core spec, otherwise LGTM. 🙌
| hostnames: | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} | ||
| rules: |
There was a problem hiding this comment.
Looking at the upstream API spec it seems we're lacking the timeouts field within rules. Can you please add it?
https://gateway-api.sigs.k8s.io/reference/spec/#httprouterule
There was a problem hiding this comment.
I can this, but I haven't seen this on any helm resource for other charts so far.
Description of the change
The Gateway API had been established as the new standard as an alternative for Ingress resources. With this change it's possible to deploy the HTTPRoute resource directly as part of the chart.
Existing or Associated Issue(s)
None
Additional Information
None
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.