[pull] master from veracrypt:master#191
Merged
Merged
Conversation
…a pool The fixed-size data pool used by LoadLanguageData() in src/Common/Language.c stores the embedded English XML strings plus the selected language's XML strings. When AddPoolData() returns NULL because the 1 MB DATA_POOL_CAPACITY is exhausted, LoadLanguageData() aborts and returns FALSE. The callers ignore the return value, so the dictionary is left partially populated: later XML entries (many controls, warnings and newer dialogs) are missing while earlier entries, including most menu items, remain translated. Since 1.26.24 the XML language files have grown enough that several languages now overflow the pool (e.g. Corsican, French, German and Dutch). Increase DATA_POOL_CAPACITY in src/Common/Dictionary.h from 1 MB to 4 MB to accommodate current and near-future translations. This regression only affects the Windows version, which uses the Win32/C localization path with this fixed pool. Linux and macOS use wxWidgets/wxTranslations and do not use src/Common/Dictionary.c for GUI localization. Fixes: GH-1587
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )