Only remove Twitter image URLs, not 3rd party media URLs#612
Only remove Twitter image URLs, not 3rd party media URLs#612IBBoard wants to merge 1 commit intobaedert:masterfrom
Conversation
This is important because Flickr and Instagram images (amongst others) may have comments and other details on the page and the URL may be integral to the content of the tweet, whereas Twitter images are reliably at the end of the tweet. We also now won't load 3rd party images when Twitter images exist because this used to lead to double-images, and we now keep the URLs
IBBoard
force-pushed
the
bug456-do-not-remove-3rd-party-image-urls
branch
from
4721796 to
a3d4ea6
Compare
|
Rebased onto Master after latest "video and preview image fix" changes |
|
This would be a nice improvement, +1 (although I do see that there are file conflicts) With this it would even be better than the official Twitter app on my phone lol (the app does keep Twitter image URL's, annoyingly). |
|
I've been meaning to check recently whether this needs further change (in addition to being updated to match the separate patch file that I use and keep up to date for my custom build - I'm never sure what the best practice is for fixing these conflicts!). While this doesn't remove 3rd party URLs, I've been wondering recently whether it has been removing Twitter URLs from the middle of the tweet. I think the best behaviour would be to only remove trailing image/quoted tweet URLs. |
2 participants
Replaces pull request #508
Only removing Twitter URLs is important because Flickr and Instagram images (amongst others) may have comments and other details on the page and the URL may be integral to the content of the tweet, whereas Twitter images are reliably at the end of the tweet.
We also now won't load 3rd party images when Twitter images exist because this used to lead to double-images, and we now keep the URLs