Skip to content
This repository was archived by the owner on Nov 13, 2018. It is now read-only.

Conversation

@AHeise
Copy link
Contributor

@AHeise AHeise commented Aug 21, 2017

No description provided.

@bakdata-bot
Copy link
Collaborator

SonarQube analysis reported 3 issues

  • MAJOR 2 major
  • MINOR 1 minor

Watch the comments in this conversation to review them.

1 extra issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR HBaseCacheStore.java#L250: Remove this unused private "createScan" method. rule

public void loadCache(IgniteBiInClosure<K, V> clo, Object... args) throws CacheLoaderException {
Scan scan = createScan(args);
Scan scan = null;//createScan(args);
Map<K, V> values = scan(scan);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Parameter 1 to this call is marked "javax.annotation.Nonnull" but null is passed. rule

@Override
public void loadCache(IgniteBiInClosure<K, V> clo, Object... args) throws CacheLoaderException {
Scan scan = createScan(args);
Scan scan = null;//createScan(args);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR This block of commented-out lines of code should be removed. rule

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants